SetProtocol / set-protocol-v2

Set Protocol V2
119 stars 94 forks source link

newFee can equals maxStreamingFeePercentage in StreamingFeeModule #224

Open gzliudan opened 2 years ago

gzliudan commented 2 years ago

In StreamingFeeModule, streamingFeePercentage can be equal to maxStreamingFeePercentage when initialize:

require(_settings.streamingFeePercentage <= _settings.maxStreamingFeePercentage, "Fee must be <= max.");

But when updateStreamingFee _newFee can't be equal to _maxStreamingFeePercentage:

require(_newFee < _maxStreamingFeePercentage(_setToken), "Fee must be less than max");

It seems that use <= to check is better.