SetProtocol / set-protocol-v2

Set Protocol V2
118 stars 94 forks source link

indexed keyword between BasicIssuanceModule and CustomOracleNavIssuanceModule are different #239

Open gzliudan opened 2 years ago

gzliudan commented 2 years ago

events have indexed keyword in BasicIssuanceModule before _issuer and _to parameter:

    event SetTokenIssued(
        address indexed _setToken,
        address indexed _issuer,
        address indexed _to,
        address _hookContract,
        uint256 _quantity
    );
    event SetTokenRedeemed(
        address indexed _setToken,
        address indexed _redeemer,
        address indexed _to,
        uint256 _quantity
    );

events have no indexed keyword in CustomOracleNavIssuanceModule and NavIssuanceModule before _issuer and _to parameter:

    event SetTokenNAVIssued(
        ISetToken indexed _setToken,
        address _issuer,
        address _to,
        address _reserveAsset,
        address _hookContract,
        uint256 _setTokenQuantity,
        uint256 _managerFee,
        uint256 _premium
    );

    event SetTokenNAVRedeemed(
        ISetToken indexed _setToken,
        address _redeemer,
        address _to,
        address _reserveAsset,
        address _hookContract,
        uint256 _setTokenQuantity,
        uint256 _managerFee,
        uint256 _premium
    );