Upgrade ethers to 5.4.6 / set-protocol-v2@0.1.0

SetProtocol / set.js

Javascript library for the Set Protocol V2

Apache License 2.0

33 stars 14 forks source link

Upgrade ethers to 5.4.6 / set-protocol-v2@0.1.0 #76

Closed cgewecke closed 2 years ago

cgewecke commented 3 years ago

Pulls in changes at set-protocol-v2 PR 131 which upgrades ethers to 5.4.6 and uses a new typechain package

Upgrades

ethers -> 5.4.6
ganache-cli -> 6.12.2
typescript -> 4.4.2
set-protocol-v2 -> 0.1.0

TODO

[x] upgrade setprotocol/set-protocol-v2 when published
[x] attribute commits to rootulp (continuation of #71)

Note: There are a handful of breaking TS interface changes here (coming from upstream at set-protocol-v2). When we publish we should bump the version to 0.3.0

rootulp commented 3 years ago

[ ] attribute commits to rootulp

This is incredibly generous. In full transparency, I contributed a very small amount to https://github.com/SetProtocol/set-protocol-v2/pull/131 but I really appreciate all your hard work to untangle this web of upgrades @cgewecke!

rootulp commented 2 years ago

we should bump the version to 0.3.0

Minor but the last release I see on GH is 0.1.0: https://github.com/SetProtocol/set.js/releases Even though 0.2.6 appears to exist per package.json https://github.com/SetProtocol/set.js/blob/master/package.json#L3

So out of curiosity, was the 0.2.x release line blacklisted? Or is 0.2.6 safe to consume and it just wasn't published to the GH releases page?

cgewecke commented 2 years ago

@rootulp The missing release for 0.2.x is an oversight. That version added some trade quote utilities that are used in TokenSets but didn't change anything else about the API here....

Will add a release for that with some usage notes...