search

SetProtocol / set.js

Javascript library for the Set Protocol V2
Apache License 2.0
33 stars 14 forks source link

Add DebtIssuanceModuleV2 factory to set.js #85

Closed williamsfu99 closed 2 years ago

williamsfu99 commented 2 years ago

Add the factory file so that we can create a debtIssuanceModuleV2 contract class (does not seem like we are renaming the class to SlippageDebtIssuanceModule for now)

Since the interface/ABI did not change we can initialize this without any bugs without bumping the package.json (since the PR is not merged into set-protocol-v2 repo yet)

In the future when we add tests to the API/Wrapper class we will bump the package so we can write tests

williamsfu99 commented 2 years ago

Confirmed with others regarding naming

justinkchen commented 2 years ago

Just confirming we're going to add the DIMv2 address to config and add api function later?