search

Setasign / tFPDF

This class is a modified version of FPDF that adds UTF-8 support.
35 stars 23 forks source link

.gitignore exludes font/unifont/ttfonts.php #4

Closed drjayvee closed 4 years ago

drjayvee commented 4 years ago

Maybe this is by design, but I'm wondering why the .gitignore contains the line font/unifont/*.php, when font/unifont/ttfonts.php is required as an autoload in composer.json.

Maybe the point was to exclude generated files like font/unifont/dejavu.mtx.php.

In that case, I would propose changing the .gitignore line to read font/unifont/*.*.*, which excludes *.cw.dat, *.mtx.php and *.cw127.php, but not ttfonts.php.

Background: I'm running into this because our project's code delivery basically does

composer install
git add --all .
git push production HEAD

Since this update, vendor/setasign/tfpdf/font/unifont/ttfonts.php is excluded, which causes problems. I can fix this in other ways, but I wanted to raise this issue.

JanSlabon commented 4 years ago

For sure you are right. It was meant to execlude generated files only.

I just added your suggestion which seems to work. Can you verify this through the master?

drjayvee commented 4 years ago

Verify? You mean create a PR against master? I'd be happy to.

Edit: nevermind, I understand what you meant. Currently testing...

JanSlabon commented 4 years ago

:-) No, I already updated .gitignore in the master. I just wanted to know if you have a way to test "setasign/tfpdf": "dev-master" in combination with this:

 composer install
 git add --all .
 git push soemthing-else HEAD

?

drjayvee commented 4 years ago

:D I can confirm that the .gitignore works as it did previously. 👍

drjayvee commented 4 years ago

Will you create a new release straight away? Otherwise I'll implement the workaround (git add -f ...) for the time being.

JanSlabon commented 4 years ago

Here you go: https://github.com/Setasign/tFPDF/releases/tag/v1.31.2