SethClydesdale / genki-study-resources

A collection of exercises for practicing what is taught in Genki: An Integrated Course in Elementary Japanese.
https://sethclydesdale.github.io/genki-study-resources/lessons-3rd/
MIT License
822 stars 280 forks source link

Lookup on text select break macOS IME #151

Closed toxinu closed 3 years ago

toxinu commented 3 years ago

When iterating over IME suggestions, macOS selects the current part of the text you are about to replace but the "lookup" tooltip appears, gets the focus, and then breaks the IME tooltip.

Here is a video:

https://user-images.githubusercontent.com/293337/138353791-0d4a4452-630f-4c65-8543-d33ad27ca45f.mov

Sorry, this is a bit tricky to explain. I don't if the solution would be to chain the way the "lookup" tooltip should appear or if having a setting to disable it would help but this is a bit annoying.

SethClydesdale commented 3 years ago

Hello @toxinu, thank you for reporting this bug!

I'll take a look into it sometime tomorrow and see what I can do. I was thinking of possibly disabling the lookup while you're actively typing, but if that doesn't work I'll introduce an option to disable this feature. I might just add the option regardless, since things like Yomichan do exist haha.

toxinu commented 3 years ago

@SethClydesdale An option would be nice and even with this "lookup" tooltip disabled, we would still be able to use the dictionary at the bottom right. 😃

SethClydesdale commented 3 years ago

Hi again!

I went ahead and added it as an option under the settings manager, which you can access via the cog at the bottom of the page or the new button added to the homepage.

Screenshot 2021-10-22 141757

If the issue still persists or if there's any other problems, do let me know!

toxinu commented 3 years ago

@SethClydesdale Yeah! That's so cool. Thanks a lot 🙇 I think we are good to move this ticket as done.

SethClydesdale commented 3 years ago

You're welcome, and thanks again for letting me know about this problem!

Hope you have a great weekend!