SethClydesdale / genki-study-resources

A collection of exercises for practicing what is taught in Genki: An Integrated Course in Elementary Japanese.
https://sethclydesdale.github.io/genki-study-resources/lessons-3rd/
MIT License
822 stars 280 forks source link

Keybinding for Hide / Show Furigana #214

Closed yangmillstheory closed 1 year ago

yangmillstheory commented 1 year ago

It'd be nice to not have to scroll down to Hide / Show Furigana. I prefer to have it hidden by default, and quickly show it when I want it, then make it go away.

SethClydesdale commented 1 year ago

Hello @yangmillstheory!

You can toggle Furigana on or off by pressing CTRL+ALT+F, there's also a few more shortcuts that you can find here. If you have any other issues or questions, let me know!

yangmillstheory commented 1 year ago

Thanks Seth, please feel free to close this issue.

On Sat, Aug 5, 2023, 23:02 Seth Clydesdale @.***> wrote:

Hello @yangmillstheory https://github.com/yangmillstheory!

You can toggle Furigana on or off by pressing CTRL+ALT+F, there's also a few more shortcuts that you can find here https://github.com/SethClydesdale/genki-study-resources#keyboard-shortcuts. If you have any other issues or questions, let me know!

β€” Reply to this email directly, view it on GitHub https://github.com/SethClydesdale/genki-study-resources/issues/214#issuecomment-1666604969, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU2I54WJRUW6Q7QJRVA4GTXT2YGFANCNFSM6AAAAAA3FMSDMI . You are receiving this because you were mentioned.Message ID: @.***>

yangmillstheory commented 1 year ago

Are the keyboard shortcuts expected to work for Mac keyboards as well?

SethClydesdale commented 1 year ago

They should, though I haven't tested since I don't own one. I believe the shortcut would be CMD+OPT+F however. If it doesn't work, let me know and I'll see about fixing it.

yangmillstheory commented 1 year ago

I just found out that Command + Option + F is "search the web" in the Chrome browser:

Screenshot 2023-08-06 at 19 35 07

I can confirm that that's what those keybindings do for me. There might be other shortcuts here that take precedence.

SethClydesdale commented 1 year ago

Thanks for letting me know! I'll look into this when I get the chance to see if I can fix this.

SethClydesdale commented 1 year ago

Hello again @yangmillstheory! I've made some minor adjustments to the shortcut handler. When you have a chance, please let me know if the CMD+OPT+F shortcut is working properly or if it's still initiating a search. Thanks!

yangmillstheory commented 1 year ago

Unfortunately it's still initiating a search. Let me know how I can help further.

On Fri, 11 Aug 2023 at 15:40, Seth Clydesdale @.***> wrote:

Hello again @yangmillstheory https://github.com/yangmillstheory! I've made some minor adjustments to the shortcut handler. When you have a chance, please let me know if the CMD+OPT+F shortcut is working properly or if it's still initiating a search. Thanks!

β€” Reply to this email directly, view it on GitHub https://github.com/SethClydesdale/genki-study-resources/issues/214#issuecomment-1674812197, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU2I5YUHIIGFDWHIHTGZCLXUYY5XANCNFSM6AAAAAA3FMSDMI . You are receiving this because you were mentioned.Message ID: @.***>

SethClydesdale commented 1 year ago

Hmm... I'll have to try looking for another solution in that case.

yangmillstheory commented 1 year ago

How about a different key binding? One that doesn't conflict with Chrome default keybindings.

On Sat, Aug 12, 2023, 02:12 Seth Clydesdale @.***> wrote:

Hmm... I'll have to try looking for another solution in that case.

β€” Reply to this email directly, view it on GitHub https://github.com/SethClydesdale/genki-study-resources/issues/214#issuecomment-1675555718, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU2I5YWQLEXUJAXRUXF7FLXU3C7BANCNFSM6AAAAAA3FMSDMI . You are receiving this because you were mentioned.Message ID: @.***>

SethClydesdale commented 1 year ago

That's what I was thinking. I'll probably setup alternate shortcut keys for mac keyboards. I'll let you know when I implement this change πŸ‘

SethClydesdale commented 1 year ago

Hello again, @yangmillstheory! I apologize for the late reply, I was taking a break since I haven't been feeling well lately.

I went and updated the key handler for the shortcuts to CMD+SHIFT+[KEY] for mac. Let me know if CMD+SHIFT+F works properly to toggle furigana or not.

yangmillstheory commented 1 year ago

γ‚γ‚ŠγŒγ¨γ†γ”γ–γ„γΎγ™οΌ