SethMMorton / fastnumbers

Super-fast and clean conversions to numbers for Python.
https://pypi.org/project/fastnumbers/
MIT License
105 stars 13 forks source link

Remove ci warnings and improve coverage #64

Closed SethMMorton closed 1 year ago

SethMMorton commented 1 year ago

This will make CI future-compatible when GitHub removes old functionality.

It will also make the coverage percentage not suck so much.

codecov[bot] commented 1 year ago

Codecov Report

Base: 89.24% // Head: 92.67% // Increases project coverage by +3.43% :tada:

Coverage data is based on head (9136a39) compared to base (d855d19). Patch coverage: 76.66% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #64 +/- ## ========================================== + Coverage 89.24% 92.67% +3.43% ========================================== Files 6 17 +11 Lines 1097 1475 +378 Branches 0 201 +201 ========================================== + Hits 979 1367 +388 + Misses 118 36 -82 - Partials 0 72 +72 ``` | [Impacted Files](https://codecov.io/gh/SethMMorton/fastnumbers/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton) | Coverage Δ | | |---|---|---| | [include/fastnumbers/parser/character.hpp](https://codecov.io/gh/SethMMorton/fastnumbers/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton#diff-aW5jbHVkZS9mYXN0bnVtYmVycy9wYXJzZXIvY2hhcmFjdGVyLmhwcA==) | `100.00% <ø> (ø)` | | | [include/fastnumbers/payload.hpp](https://codecov.io/gh/SethMMorton/fastnumbers/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton#diff-aW5jbHVkZS9mYXN0bnVtYmVycy9wYXlsb2FkLmhwcA==) | `100.00% <ø> (ø)` | | | [include/fastnumbers/resolver.hpp](https://codecov.io/gh/SethMMorton/fastnumbers/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton#diff-aW5jbHVkZS9mYXN0bnVtYmVycy9yZXNvbHZlci5ocHA=) | `98.07% <ø> (ø)` | | | [src/cpp/c\_str\_parsing.cpp](https://codecov.io/gh/SethMMorton/fastnumbers/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton#diff-c3JjL2NwcC9jX3N0cl9wYXJzaW5nLmNwcA==) | `98.06% <ø> (-1.30%)` | :arrow_down: | | [src/cpp/fastnumbers.cpp](https://codecov.io/gh/SethMMorton/fastnumbers/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton#diff-c3JjL2NwcC9mYXN0bnVtYmVycy5jcHA=) | `90.30% <0.00%> (+2.45%)` | :arrow_up: | | [include/fastnumbers/evaluator.hpp](https://codecov.io/gh/SethMMorton/fastnumbers/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton#diff-aW5jbHVkZS9mYXN0bnVtYmVycy9ldmFsdWF0b3IuaHBw) | `74.73% <66.66%> (ø)` | | | [include/fastnumbers/parser/numeric.hpp](https://codecov.io/gh/SethMMorton/fastnumbers/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton#diff-aW5jbHVkZS9mYXN0bnVtYmVycy9wYXJzZXIvbnVtZXJpYy5ocHA=) | `92.30% <77.77%> (ø)` | | | [include/fastnumbers/extractor.hpp](https://codecov.io/gh/SethMMorton/fastnumbers/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton#diff-aW5jbHVkZS9mYXN0bnVtYmVycy9leHRyYWN0b3IuaHBw) | `100.00% <100.00%> (ø)` | | | [include/fastnumbers/parser/base.hpp](https://codecov.io/gh/SethMMorton/fastnumbers/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton#diff-aW5jbHVkZS9mYXN0bnVtYmVycy9wYXJzZXIvYmFzZS5ocHA=) | `100.00% <100.00%> (ø)` | | | [include/fastnumbers/parser/unicode.hpp](https://codecov.io/gh/SethMMorton/fastnumbers/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton#diff-aW5jbHVkZS9mYXN0bnVtYmVycy9wYXJzZXIvdW5pY29kZS5ocHA=) | `95.12% <100.00%> (ø)` | | | ... and [20 more](https://codecov.io/gh/SethMMorton/fastnumbers/pull/64?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.