SethMMorton / natsort

Simple yet flexible natural sorting in Python.
https://pypi.org/project/natsort/
MIT License
895 stars 50 forks source link

Disable extension splitting on Windows for os_sorted #166

Closed SethMMorton closed 1 year ago

SethMMorton commented 1 year ago

It turns out that this is not a behavior that Windows supports - it adds e.g. (2) after the extension, not before, so it does not account for extensions when sorting.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (51b2fd3) 98.51% compared to head (b7ad1cb) 98.51%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #166 +/- ## ======================================= Coverage 98.51% 98.51% ======================================= Files 10 10 Lines 606 607 +1 ======================================= + Hits 597 598 +1 Misses 9 9 ``` | [Impacted Files](https://app.codecov.io/gh/SethMMorton/natsort/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton) | Coverage Δ | | |---|---|---| | [natsort/natsort.py](https://app.codecov.io/gh/SethMMorton/natsort/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton#diff-bmF0c29ydC9uYXRzb3J0LnB5) | `100.00% <100.00%> (ø)` | | | [natsort/utils.py](https://app.codecov.io/gh/SethMMorton/natsort/pull/166?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Seth+Morton#diff-bmF0c29ydC91dGlscy5weQ==) | `97.27% <100.00%> (+0.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.