search

Setono / SyliusFeedPlugin

Create feeds in your Sylius shop
MIT License
24 stars 44 forks source link

Doctrine/persistence bundle compatibility #93

Open PeterMagyar opened 3 months ago

PeterMagyar commented 3 months ago

I tried to add this bundle to a sylius project(v.1.12.13) sf(6.4). According to composer its not possible because it's requirement is ^1.3 || ^2.0

and my project doctrine/persistence version is 3..2

loevgaard commented 3 months ago

Could you open a PR? :)

PeterMagyar commented 3 months ago

I really would like to but i found many other issue with compatibility. For example : setono/doctrine-orm-batcher[v0.6.0, ..., v0.6.1] require php ^7.1 -> your php version (8.1.13) does not satisfy that requirement.

It seems like the "problem" is much more deeper than i thought at first :)

loevgaard commented 3 months ago

What happens if you try to downgrade your own dependency?

PeterMagyar commented 3 months ago

I would prefer to not downgrade any the bundles.

I tried it just for see that works or not. The composer require command with (--with-all-dependencies -- to downgrade where necessary) also failed. So it would not solve the problem either.

encreinformatique commented 1 month ago

It is coming from symfony/doctrine-bridge in 6.4 branch. They dropped support for doctrine/persistence 2. It means we do have to stick to Symfony 5.4 LTS or a unmaintain version of the Sf bundles. (unacceptable in our case)

I prepared a PR but if it goes as in my fork, both static tests and integration won't pass although those files were not modified. I do not use Behat so I do not know if it related to compatibility or recent change.

Error: src/Controller/Action/Shop/ShowFeedAction.php:87:17: RiskyTruthyFalsyComparison: Operand of type bool|mixed contains type mixed, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
Error: src/DataProvider/DataProvider.php:94:63: ArgumentTypeCoercion: Argument 1 of Doctrine\Persistence\ManagerRegistry::getManagerForClass expects class-string, but parent type string provided (see https://psalm.dev/193)

and

PHP Fatal error:  Declaration of Behat\Mink\Driver\Selenium2Driver::visit(string $url) must be compatible with Behat\Mink\Driver\CoreDriver::visit($url) in /home/runner/work/SyliusFeedPlugin/SyliusFeedPlugin/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php on line 401

edit: I just saw the master branch is having those problems so definitively not related to the PR.