Setono / SyliusGiftCardPlugin

Sell gift cards on your Sylius store and let users use them in the checkout process
MIT License
45 stars 39 forks source link

Adding ValidFrom and ValidUntil dates #169

Closed Roshyo closed 2 years ago

Roshyo commented 2 years ago

We should be able to define when a Gift Card is expiring. Let's say that some of them should be valid for 2 years, and some others for 6 months, depending on the needs. So a Gift Card should have a validFrom and a validUntil dates

loevgaard commented 2 years ago

For this issue I think we should have a configuration option; default_validity_period - probably given in days or hours.

I am not sure we need the 'validFrom' though. What's the use case for that?