Setono / SyliusGiftCardPlugin

Sell gift cards on your Sylius store and let users use them in the checkout process
MIT License
45 stars 39 forks source link

Make 0.11 branch compatible with Sylius 1.9 #173

Closed Roshyo closed 2 years ago

Roshyo commented 2 years ago

Fixes #160

Merge this OR #172 but not both of them.

codecov[bot] commented 2 years ago

Codecov Report

Merging #173 (80b283f) into 0.11.x (072f481) will increase coverage by 0.07%. The diff coverage is 0.00%.

:exclamation: Current head 80b283f differs from pull request most recent head b61de55. Consider uploading reports for the commit b61de55 to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##             0.11.x    #173      +/-   ##
===========================================
+ Coverage      9.51%   9.59%   +0.07%     
  Complexity      360     360              
===========================================
  Files            63      63              
  Lines          1166    1157       -9     
===========================================
  Hits            111     111              
+ Misses         1055    1046       -9     
Impacted Files Coverage Δ
src/Controller/Action/AddGiftCardToOrderAction.php 0.00% <0.00%> (ø)
src/Controller/Action/GiftCardBalanceAction.php 0.00% <0.00%> (ø)
src/Controller/Action/SearchGiftCardAction.php 0.00% <0.00%> (ø)
...endencyInjection/SetonoSyliusGiftCardExtension.php 70.00% <ø> (ø)
...istener/DefaultGiftCardConfigurationSubscriber.php 0.00% <ø> (ø)
src/Model/GiftCard.php 6.89% <ø> (ø)
src/Model/GiftCardConfiguration.php 0.00% <ø> (ø)
.../Provider/GiftCardChannelConfigurationProvider.php 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 072f481...b61de55. Read the comment docs.

loevgaard commented 2 years ago

I think this PR can be closed?