Setono / SyliusGiftCardPlugin

Sell gift cards on your Sylius store and let users use them in the checkout process
MIT License
45 stars 39 forks source link

Allow to define custom rendering options for wkhtmltopdf #185

Closed Roshyo closed 2 years ago

Roshyo commented 2 years ago

Fixes #184

codecov[bot] commented 2 years ago

Codecov Report

Merging #185 (118fd47) into 0.12.x (170e50c) will increase coverage by 3.89%. The diff coverage is 84.88%.

:exclamation: Current head 118fd47 differs from pull request most recent head 8776ccb. Consider uploading reports for the commit 8776ccb to get more accurate results

@@             Coverage Diff              @@
##             0.12.x     #185      +/-   ##
============================================
+ Coverage     41.85%   45.75%   +3.89%     
- Complexity      483      501      +18     
============================================
  Files            92       94       +2     
  Lines          1560     1567       +7     
============================================
+ Hits            653      717      +64     
+ Misses          907      850      -57     
Impacted Files Coverage Δ
src/Form/Type/GiftCardConfigurationType.php 0.00% <0.00%> (ø)
src/Generator/GiftCardCodeGenerator.php 0.00% <0.00%> (ø)
src/DependencyInjection/Configuration.php 100.00% <100.00%> (ø)
...endencyInjection/SetonoSyliusGiftCardExtension.php 83.33% <100.00%> (+13.33%) :arrow_up:
src/Factory/GiftCardConfigurationFactory.php 100.00% <100.00%> (+100.00%) :arrow_up:
src/Generator/GiftCardPdfGenerator.php 100.00% <100.00%> (ø)
src/Model/GiftCardConfiguration.php 83.09% <100.00%> (+1.84%) :arrow_up:
src/Provider/PdfRenderingOptionsProvider.php 100.00% <100.00%> (ø)
...ator/Constraints/Pdf/ValidOrientationValidator.php 100.00% <100.00%> (ø)
...lidator/Constraints/Pdf/ValidPageSizeValidator.php 100.00% <100.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 170e50c...8776ccb. Read the comment docs.

loevgaard commented 2 years ago

Very nice PR, Stephane 🎉