Setono / SyliusGiftCardPlugin

Sell gift cards on your Sylius store and let users use them in the checkout process
MIT License
44 stars 39 forks source link

Simplified the configuration template #243

Closed loevgaard closed 1 year ago

loevgaard commented 1 year ago

Simplified the template (hopefully) by making it really transparent what was rendered

codecov[bot] commented 1 year ago

Codecov Report

Base: 45.56% // Head: 45.64% // Increases project coverage by +0.08% :tada:

Coverage data is based on head (018b377) compared to base (9581d9d). Patch coverage: 66.66% of modified lines in pull request are covered.

:exclamation: Current head 018b377 differs from pull request most recent head 90e5dae. Consider uploading reports for the commit 90e5dae to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.12.x #243 +/- ## ============================================ + Coverage 45.56% 45.64% +0.08% Complexity 589 589 ============================================ Files 109 109 Lines 1826 1827 +1 ============================================ + Hits 832 834 +2 + Misses 994 993 -1 ``` | [Impacted Files](https://codecov.io/gh/Setono/SyliusGiftCardPlugin/pull/243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Setono) | Coverage Δ | | |---|---|---| | [...rovider/DefaultGiftCardTemplateContentProvider.php](https://codecov.io/gh/Setono/SyliusGiftCardPlugin/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Setono#diff-c3JjL1Byb3ZpZGVyL0RlZmF1bHRHaWZ0Q2FyZFRlbXBsYXRlQ29udGVudFByb3ZpZGVyLnBocA==) | `0.00% <0.00%> (ø)` | | | [src/Renderer/PdfRenderer.php](https://codecov.io/gh/Setono/SyliusGiftCardPlugin/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Setono#diff-c3JjL1JlbmRlcmVyL1BkZlJlbmRlcmVyLnBocA==) | `0.00% <ø> (ø)` | | | [src/Factory/GiftCardFactory.php](https://codecov.io/gh/Setono/SyliusGiftCardPlugin/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Setono#diff-c3JjL0ZhY3RvcnkvR2lmdENhcmRGYWN0b3J5LnBocA==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Setono). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Setono)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.