Setono / SyliusGiftCardPlugin

Sell gift cards on your Sylius store and let users use them in the checkout process
MIT License
44 stars 39 forks source link

Move the flush of order outside the applicator #244

Closed loevgaard closed 1 year ago

loevgaard commented 1 year ago

Move the flush of order outside the applicator because flushes are handled by Doctrine middleware for Symfony messages

codecov[bot] commented 1 year ago

Codecov Report

Base: 41.60% // Head: 41.58% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (e6550f5) compared to base (0d934ad). Patch coverage: 0.00% of modified lines in pull request are covered.

:exclamation: Current head e6550f5 differs from pull request most recent head 258b1ad. Consider uploading reports for the commit 258b1ad to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.12.x #244 +/- ## ============================================ - Coverage 41.60% 41.58% -0.02% Complexity 590 590 ============================================ Files 108 108 Lines 2103 2104 +1 ============================================ Hits 875 875 - Misses 1228 1229 +1 ``` | [Impacted Files](https://codecov.io/gh/Setono/SyliusGiftCardPlugin/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Setono) | Coverage Δ | | |---|---|---| | [src/Applicator/GiftCardApplicator.php](https://codecov.io/gh/Setono/SyliusGiftCardPlugin/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Setono#diff-c3JjL0FwcGxpY2F0b3IvR2lmdENhcmRBcHBsaWNhdG9yLnBocA==) | `0.00% <ø> (ø)` | | | [src/Controller/Action/AddGiftCardToOrderAction.php](https://codecov.io/gh/Setono/SyliusGiftCardPlugin/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Setono#diff-c3JjL0NvbnRyb2xsZXIvQWN0aW9uL0FkZEdpZnRDYXJkVG9PcmRlckFjdGlvbi5waHA=) | `0.00% <0.00%> (ø)` | | | [...ontroller/Action/RemoveGiftCardFromOrderAction.php](https://codecov.io/gh/Setono/SyliusGiftCardPlugin/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Setono#diff-c3JjL0NvbnRyb2xsZXIvQWN0aW9uL1JlbW92ZUdpZnRDYXJkRnJvbU9yZGVyQWN0aW9uLnBocA==) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Setono). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Setono)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.