search

Setono / SyliusGiftCardPlugin

Sell gift cards on your Sylius store and let users use them in the checkout process
MIT License
44 stars 39 forks source link

Add support for PHP 8 attributes in Trait #263

Open vasilvestre opened 4 months ago

vasilvestre commented 4 months ago

Tested in my own project

loevgaard commented 4 months ago

I have never tried this 'mixing' of attributes and annotations. Does this work without any problems?

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.30%. Comparing base (149b15c) to head (3fb3b58).

:exclamation: Current head 3fb3b58 differs from pull request most recent head 3f31faf

Please upload reports for the commit 3f31faf to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.12.x #263 +/- ## ============================================ - Coverage 41.33% 41.30% -0.03% - Complexity 594 597 +3 ============================================ Files 107 108 +1 Lines 2100 2116 +16 ============================================ + Hits 868 874 +6 - Misses 1232 1242 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vasilvestre commented 4 months ago

I have never tried this 'mixing' of attributes and annotations. Does this work without any problems?

I've tried it locally and had no issue with annotation. I haven't tested both cases

loevgaard commented 3 months ago

Hi, @vasilvestre. Can you rebase this on 0.12? Then we will merge it. Thank you 🎉

vasilvestre commented 1 month ago

Done ! Sorry for the delay