search

Setono / SyliusRedirectPlugin

Add redirects to your Sylius store from a simple interface
MIT License
22 stars 24 forks source link

Incompatibility with Sylius 1.9 #71

Closed MacBim closed 3 years ago

MacBim commented 3 years ago

Plugin version : v2.1.1 Sylius version : 1.9

With the recent Sylius 1.9 update, the plugin is not compatible anymore and won't work You systematically get this error :

Argument 1 passed to Setono\SyliusRedirectPlugin\EventListener\NotFoundSubscriber::__construct() must be an instance of Doctrine\Common\Persistence\ObjectManager, instance of EntityManager_9a5be93 given, called in /Users/user/PhpstormProjects/sylius/var/cache/dev/ContainerXhzYauW/getSetonoSyliusRedirect_EventListener_NotFoundService.php on line 11

loevgaard commented 3 years ago

Can you make a PR fixing this? :)

MacBim commented 3 years ago

Sure, I'll submit a PR shortly !

loevgaard commented 3 years ago

Cool :)

MacBim commented 3 years ago

Here is the PR : https://github.com/Setono/SyliusRedirectPlugin/pull/72

MacBim commented 3 years ago

@loevgaard A follow-up to PR #72 : I forgot to actually updates the dependencies of the plugin. This should be fixed in #73