search

Setono / SyliusTermsPlugin

Add terms and conditions to your Sylius store and have the customer accept them on checkout
MIT License
34 stars 12 forks source link

Blocking order completion in backend #11

Closed 4c0n closed 9 months ago

4c0n commented 5 years ago

Currently it seems that order completion is only blocked on a UI/Form level. More specifically the form cannot be submitted without accepting the terms.

It seems that tech savvy users could circumvent that measure by submitting the request directly (without using the UI) without truly accepting the terms.

In my opinion it would be great to add a feature that blocks the state machine transition if the terms are not (all) accepted. That can be done by adding a callback to the state machine, for example.

loevgaard commented 5 years ago

Hi @4c0n

I think you are right, however, do you believe it to be a big problem that we should prioritize right now, or is it okay to just keep this issue open and fix it within the next 6-9 months?

4c0n commented 5 years ago

@loevgaard No rush, just wanted to put this on the map. If it turns out I'll need it sooner, I'll implement it in a fork and send you a PR.

loevgaard commented 5 years ago

Thanks :)

loevgaard commented 9 months ago

I will close this for now, as I don't consider it a big problem