search

Setono / SyliusTermsPlugin

Add terms and conditions to your Sylius store and have the customer accept them on checkout
MIT License
34 stars 12 forks source link

Version 1.0.7 is not installed for sylius 1.10 #41

Closed dsbe-ak closed 3 years ago

dsbe-ak commented 3 years ago

After executing composer create-project sylius/sylius-standard acme

And then composer require setono/sylius-terms-plugin

only version 1.0.6 is installed (because of dependencies?).

The admin template "SyliusAdminBundle:Crud" is then not found.

How can I install 1.0.7 for sylius 1.10? Thanks!

loevgaard commented 3 years ago

Hi, @dsbe-ak

Can you make a PR that will allow it work with 1.10? If not, can you provide some more context, i.e. what packages are blocking?

RomulusED69 commented 3 years ago

I have same problem. Try localy and I have any problems:

loevgaard commented 3 years ago

@RomulusED69: Can you provide a PR? :)

dsbe-ak commented 3 years ago

Well I've just retested, and I guess it is working if you're fine with symfony 4.4. But if you have other bundles, who rely on symfony 5.3, it's not working (in my case).

So after setting the version to 1.0.7 in composer.json, composer is downgrading to symfony 4.4:

Removing psr/event-dispatcher (1.0.0) Removing symfony/password-hasher (v5.3.3) Downgrading fakerphp/faker (v1.15.0 => v1.9.2) Downgrading nelmio/alice (v3.8.2 => 3.7.3) Upgrading setono/sylius-terms-plugin (v1.0.6 => v1.0.7) Downgrading symfony/console (v5.3.2 => v4.4.26) Locking symfony/debug (v4.4.25) Downgrading symfony/doctrine-bridge (v5.3.3 => v4.4.25) Downgrading symfony/error-handler (v5.3.3 => v4.4.26) Downgrading symfony/event-dispatcher (v5.3.0 => v4.4.25) Downgrading symfony/event-dispatcher-contracts (v2.4.0 => v1.1.9) Downgrading symfony/framework-bundle (v5.3.3 => v4.4.26) Downgrading symfony/http-kernel (v5.3.3 => v4.4.26) Downgrading symfony/monolog-bridge (v5.3.3 => v5.2.11) Downgrading symfony/security-bundle (v5.3.3 => v4.4.26) Downgrading symfony/security-core (v5.3.3 => v4.4.26) Downgrading symfony/security-guard (v5.3.0 => v4.4.26) Downgrading symfony/security-http (v5.3.3 => v4.4.26) Downgrading symfony/translation (v5.3.3 => v4.4.26) Downgrading symfony/translation-contracts (v2.4.0 => v1.1.10) Downgrading symfony/twig-bridge (v5.3.3 => v4.4.26) Downgrading symfony/twig-bundle (v5.3.3 => v4.4.26) Downgrading symfony/web-link (v5.3.3 => v5.2.11) Downgrading symfony/web-profiler-bundle (v5.3.2 => v4.4.26)

loevgaard commented 3 years ago

You can do a composer why-not symfony/framework-bundle:5.3 and it will tell you why. If you could paste that output here it would be nice. I suspect it's something along the lines of what @RomulusED69 wrote

RomulusED69 commented 3 years ago

this https://github.com/Setono/SyliusTermsPlugin/pull/40 seems ok for fix problem I see @loevgaard

dsbe-ak commented 3 years ago

Here's the output of composer why-not symfony/framework-bundle:5.3

symfony/framework-bundle v5.3.0 conflicts symfony/console (<5.2.5) symfony/framework-bundle v5.3.0 conflicts symfony/security-core (<5.3) symfony/framework-bundle v5.3.0 conflicts symfony/translation (<5.3) symfony/framework-bundle v5.3.0 requires symfony/event-dispatcher (^5.1) root - does not require symfony/event-dispatcher (but v4.4.25 is installed) symfony/framework-bundle v5.3.0 requires symfony/http-kernel (^5.3) root - does not require symfony/http-kernel (but v4.4.26 is installed)

michaelKaefer commented 3 years ago

@loevgaard In my case it is not working because of PHP 8 (which is supported by Sylius 1.10):

$ composer require setono/sylius-terms-plugin:^1.0.7

  Package setono/sylius-terms-plugin at version ^1.0.7 has a PHP requirement 
incompatible with your PHP version, PHP extensions and Composer version

(It also says something about my Composer version, I use Composer 2)

loevgaard commented 3 years ago

Hi, everybody. Can you please confirm that Sylius 1.10 is compatible with the latest changes in master?

loevgaard commented 3 years ago

If it is then I will release a new version of this plugin

RomulusED69 commented 3 years ago

@loevgaard it's ok for me with sylius 1.9 I can't test with 1.10 and php8 in my project. thx for the fix

dsbe-ak commented 3 years ago

working for me now, composer is upgrading to symfony 5.3:

michaelKaefer commented 3 years ago

Thank you, dev-master is working for me with PHP 8 and Sylius 1.10.

dsbe-ak commented 3 years ago

Any update on the new version?

loevgaard commented 3 years ago

Released as 1.0.8 now :)

dsbe-ak commented 3 years ago

Works as expected, thank you!