search

SettingDust / ModSets

Minecraft mod for managing mod loading
MIT License
11 stars 4 forks source link

Crashing when trying to open the config screen #6

Closed craftish37 closed 1 year ago

craftish37 commented 1 year ago

Playing on Quilt 1.20.1 - 0.20.0-beta.4 ModSets version 1.2 - 1.20.1

When trying to open the config via modmenu, game crashes with this output

SettingDust commented 1 year ago

I can't reproduce it in development. Can your provide your config and mods?

craftish37 commented 1 year ago

Sure, will a zip do it ?

SettingDust commented 1 year ago

Sure, will a zip do it ?

ya

SettingDust commented 1 year ago

mod_sets-1.2.0+1.20.1-fabric-intermediary.zip Can you test with this first? Maybe it get fixed

craftish37 commented 1 year ago

https://www.mediafire.com/file/rtcxcfn376rsdr6/instance.zip/file I will test it in some hours, gotta go quickly

SettingDust commented 1 year ago

notice. It won't load sub fir more than depth 1. Since there is defined mod sets for complex config and you can't publish the tree to platform like CurseForge

SettingDust commented 1 year ago

Hm. It appears randomly. Can't reproduce stable.

SettingDust commented 1 year ago

notice. It won't load sub fir more than depth 1. Since there is defined mod sets for complex config and you can't publish the tree to platform like CurseForge

Well. ModSets load sub dir on fabric and forge but not quilt. It depends on how the quilt load it.

SettingDust commented 1 year ago

And I reproduce the issue. Causing by there isn't any rules. I'll fix it in next version

SettingDust commented 1 year ago

https://modrinth.com/mod/mod-sets/version/hfdtZhTP

craftish37 commented 1 year ago

Updated to 1.2.1, got a new issue image

Extract from logs :

Error from mod 'mod_sets'
java.util.ConcurrentModificationException
    at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1597)
    at java.base/java.util.HashMap$EntryIterator.next(HashMap.java:1630)
    at java.base/java.util.HashMap$EntryIterator.next(HashMap.java:1628)
    at settingdust.modsets.game.Rules.getConfig(Rules.kt:171)
    at settingdust.modsets.game.Rules.createScreen(Rules.kt:162)
    at settingdust.modsets.game.ModSetsModMenu.getModConfigScreenFactory$lambda$0(ModSetsModMenu.kt:9)
    at com.terraformersmc.modmenu.ModMenu.getConfigScreen(ModMenu.java:61)
    at com.terraformersmc.modmenu.gui.ModsScreen.method_25426(ModsScreen.java:114)
    at net.minecraft.class_437.method_25423(class_437.java:297)
    at net.minecraft.class_310.method_1507(class_310.java:1080)
    at com.terraformersmc.modmenu.gui.widget.ModMenuButtonWidget.lambda$new$0(ModMenuButtonWidget.java:15)
    at net.minecraft.class_4185.method_25306(class_4185.java:94)
    at net.minecraft.class_4264.method_25348(class_4264.java:56)
    at net.minecraft.class_339.method_25402(class_339.java:189)
    at net.minecraft.class_4069.method_25402(class_4069.java:38)
    at net.minecraft.class_442.method_25402(class_442.java:299)
    at net.minecraft.class_312.method_1611(class_312.java:98)
    at net.minecraft.class_437.method_25412(class_437.java:409)
    at net.minecraft.class_312.method_1601(class_312.java:98)
    at net.minecraft.class_312.method_22686(class_312.java:169)
    at net.minecraft.class_1255.execute(class_1255.java:102)
    at net.minecraft.class_312.method_22684(class_312.java:169)
    at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43)
    at org.lwjgl.system.JNI.invokeV(Native Method)
    at org.lwjgl.glfw.GLFW.glfwWaitEventsTimeout(GLFW.java:3474)
    at com.mojang.blaze3d.systems.RenderSystem.limitDisplayFPS(RenderSystem.java:237)
    at net.minecraft.class_310.method_1523(class_310.java:1244)
    at net.minecraft.class_310.method_1514(class_310.java:802)
    at net.minecraft.client.main.Main.main(Main.java:250)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.base/java.lang.reflect.Method.invoke(Method.java:568)
    at org.quiltmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:524)
    at org.quiltmc.loader.impl.launch.knot.Knot.launch(Knot.java:82)
    at org.quiltmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:28)
SettingDust commented 1 year ago

Hmmm. It's seems the old one.

SettingDust commented 1 year ago

Hmmm. It's seems the old one.

No-op. It won't crash. And will be fine at second time. Need explain

craftish37 commented 1 year ago

Well I restarted the game multiple times and still encounter this issue As for explainations I'm not quite sure what kind of information you may need more

SettingDust commented 1 year ago

Well I restarted the game multiple times and still encounter this issue As for explainations I'm not quite sure what kind of information you may need more

Just reenter the mod menu not works?

craftish37 commented 1 year ago

Fixed, thank you so much 😄