search

SettleScape / server

The configuration for SettleScape™, a high-quality, community-minded Minecraft server.
http://SettleScape.org
Other
5 stars 2 forks source link

Combine Towny Layers #189

Closed MilesBHuff closed 2 weeks ago

MilesBHuff commented 10 months ago

Now that https://github.com/TownyAdvanced/Towny/issues/6074 has been completed, we can finally merge TownyRuins with the standard Towny layer. (TownyCamps would be kept separate.)

MilesBHuff commented 2 weeks ago

This has been done, but TownyHistories seems to use its own markerset, and this is not configurable. Thankfully, the ruins on my map seem to render in the normal Towny map layer instead of the TownyHistories one, which means that I can just disable the unused TownyHistories Dynmap integration. However, this feels like a bug. @LlmDl is this a bug? I wonder if Dynmap-Towny and TownyHistories are fighting with each other (There's a ruinicon: temple in plugins/Dynmap-Towny/config.yml, and a marker_icon: temple in minecraft/plugins/TownyHistories/config.yml.). There should probably be only one source of truth for that, right? Or am I misunderstand something? Are Towny's "ruin"s and TownyHistories' "ruin"s the same thing, or different things? Sorry for the ping. I can formally report it as a bug over at TownyAdvanced if you think it is, but I wanted to ask first.

Relevant commits: d6cefcceb34c336c88a3b97e833d56ed9d618ba5 47041eda31710289a031d04973df1e008e9de7e8

MilesBHuff commented 2 weeks ago

Actually, there's seemingly a second bug in here: dynmap_layer_name from TownyCamps and TownyHistories (implemented in https://github.com/TownyAdvanced/Towny/issues/6074) doesn't actually let us merge markersets -- it only lets us rename a fixed markerset.

I'll take this over to the completed issue at TownyAdvanced -- I think there was just a misunderstanding around what the ask was.