Settlers4Modding / CommunityPatchLauncher

This is the tool for patching Settlers 4 History Edition to the most recent community patch level. It also helps you switching between the different versions of the game.
MIT License
4 stars 0 forks source link

[BUG] Fast keys for new building are annoying and work even outside Settlers #136

Open Jasperdg65 opened 3 years ago

Jasperdg65 commented 3 years ago

Bug Keypress anywhere in Windows starts a building in Settlers.

Description Only in the community patch (4.66.1528) some keys on the keyboard initiate a builing in the Settlers game. This is very annoying because it happens when you type a message in Settlers, but even more annoying is the fact that pressing the keys works everywhere within Windows. When I type an e-mail, a building is initiated.

Discovered keys so far

To Reproduce Steps to reproduce the behavior:

  1. Start Settlers Community Patch or Community Patch PTR (using Community Patch Launcher 0.0.1)
  2. Click on Single Player
  3. Click on Choose Map
  4. Select any map with enough space to build
  5. Click Ok on the Map Settings screen
  6. Click Ok on the Game Settings screen
  7. Click on any other program in Windows to set the focus away from Settlers
  8. Type any of the keys listed above

Expected behavior

  1. Keys typed outside the Settlers programs should never be captured within Settlers!
  2. Keys should neither be captured in the message box in Settlers
github-actions[bot] commented 3 years ago

Welcome onboard, thank you for beeing part of this project

Pumpline commented 3 years ago

Hey! This is not a Bug from the Launcher, this has something to do with the Hotkey Plugin made by @WizzardMaker. He will have a look at it asap. Greetings

Jasperdg65 commented 3 years ago

I think it is a very dangerous plugin. This means that Settlers can capture all our keyboard actions and send any and all information somewehere without us knowing it.

Pumpline commented 3 years ago

The plugin does not save any keyboard actions. He only reacts to a amount of keys. I know that u are quite confused about this. Wizzard will try to fix this asap. Greetings

Pumpline commented 3 years ago

If you want more information about this, you can wait here until WizzardMaker arrives or visit our Discord Server: http://discord.gg/Vhs3e5N

Jasperdg65 commented 3 years ago

Hey Ausgeben and Wizzard: Asap promises soon. Now, 4 days later and after syncing patches the problem remains.

WizzardMaker commented 3 years ago

The problem is on the to do list for the hotkeys plugin

I can't give an ETA though

Jasperdg65 commented 3 years ago

I understand. It's very annoying. Just now I tried the history edition through the community patch launcher, same problem. And even starting the history edition directly has the same problem. Whilst typing this message, Settlers begins building all kinds of buildings.

Pumpline commented 3 years ago

Select the He via the Launcher and then start the game