Open SMS activity toasts a message saying the SMS permission wasn't accepts, which isn't true.

Seva-coder / Finder

Application for remote phone search

GNU General Public License v3.0

115 stars 23 forks source link

Open SMS activity toasts a message saying the SMS permission wasn't accepts, which isn't true. #2

Closed realrufans closed 5 years ago

realrufans commented 5 years ago

Expected behavior

I expect it to recognise that the SMS permission was accepted.

Actual behavior

Open SMS activity toasts a message saying the SMS permission wasn't accepted, which isn't true.

How to reproduce

launch the app, accept the permissions
Navigate to open SMS tab
watch the page not function (it will toast a message saying the permission wasn't granted.).

Browser/App version:

Finder v1.5

Operating system:

Android 0

Recording Of The Bug

Seva-coder commented 5 years ago

@realrufans yes, it was a bug. Oreo have more strict permission check, and I forgot to add "READ_SMS" at start. But on older version of android it works. Now it will be fixed. Moreover, Oreo itself have an important bug, which is expressed in necessity of "READ_PHONE_STARE" permission to send SMS! I also add this case (only for 8.0, 26 api) (discussed here - https://issuetracker.google.com/issues/66979952) thanks for testing)

Seva-coder commented 5 years ago

fixed in v1.6

realrufans commented 5 years ago

Thanks