Open zarifpour opened 1 year ago
Thanks for contributing! Could you split the PR between the streamlined installation changes and black and ruff changes? Want to consider those changes separately. Also I think we should ignore linting custom_speech_recognition since its just a copy of the existing SpeechRecognition library with some modifications. Probably a better way to maintain that I haven't considered how.
Thanks for contributing! Could you split the PR between the streamlined installation changes and black and ruff changes? Want to consider those changes separately. Also I think we should ignore linting custom_speech_recognition since its just a copy of the existing SpeechRecognition library with some modifications. Probably a better way to maintain that I haven't considered how.
I see, I didn't realize it was a copy of an existing SpeechRecognition library. In that case, I will ignore it in regards to linting and formatting. Would it make sense to do something like this - where the library is its own git repo?
Example from: https://github.com/foundry-rs/foundry-rust-template/tree/master/contracts/lib
Not sure why but make lint and make format cant find python files
Not sure why but make lint and make format cant find python files
Hmm, I'm not sure. Maybe the way black behaves is different on windows. Can you try modifying a python file to contain single quotes for a string, instead of double quotes, and see if you get the same message. Perhaps it's behaving normally?
I think this is good to go. If you get a chance to review + merge, I would appreciate it. Thanks!
I added black and ruff to maintain code quality and implemented a Makefile streamline the execution of common commands.
I also tried to add poetry as the dependency manager, but it was not compatible with the dependency
openai-whisper
. It seemed to consistently fail on the installation oftritton
.For reference, this is as far as I was able to get:
It fails with this error (there was another one for tritton, but I seemed to have lost it somewhere in my console):
I noticed another developer had a similar issue: https://github.com/orgs/python-poetry/discussions/7199