search

SevaSk / ecoute

Ecoute is a live transcription tool that provides real-time transcripts for both the user's microphone input (You) and the user's speakers output (Speaker) in a textbox. It also generates a suggested response using OpenAI's GPT-3.5 for the user to say based on the live transcription of the conversation.
https://github.com/SevaSk/ecoute
MIT License
5.85k stars 817 forks source link

Added reverse engineered ChatGPT API #96

Open lunjielee opened 1 year ago

lunjielee commented 1 year ago

Hi, @SevaSk,

I hope you're doing well. I wanted to let you know about a PR that I've submitted. It introduces a new feature to ecoute, allowing users to utilize it without the need for a paid OpenAI account. Could you please take a look and provide your feedback?

Thanks, Lunjie

SevaSk commented 1 year ago

Hmm not sure its OK to merge since this is probably not legal. Also for design I prefer to follow the tell, don't ask principle. Here why are we asking if the revChatGPT flag is set every time we want generate a response? Wouldn't it be better to tell the class to override the different response generation functionally once at the beginning of the program instead? No need to complicate class with more flags.

lunjielee commented 1 year ago

Hmm not sure its OK to merge since this is probably not legal. Also for design I prefer to follow the tell, don't ask principle. Here why are we asking if the revChatGPT flag is set every time we want generate a response? Wouldn't it be better to tell the class to override the different response generation functionally once at the beginning of the program instead? No need to complicate class with more flags.

With regards to the first question, are you stating that merging the code is prohibited due to license issues or the utilization of a reverse-engineered API?

Regarding the second question, you are absolutely right. It is preferable to adhere to the "tell, don't ask" principle. I will ensure to modify that section of the code accordingly.

Lunjie

Rakshay-pawar commented 9 months ago

Hmm not sure its OK to merge since this is probably not legal. Also for design I prefer to follow the tell, don't ask principle. Here why are we asking if the revChatGPT flag is set every time we want generate a response? Wouldn't it be better to tell the class to override the different response generation functionally once at the beginning of the program instead? No need to complicate class with more flags.

Lunjie Hi Lunjie I downloaded your files and replaced them with the original files however I am getting an error "ImportError: cannot import name 'ACCESS_TOKEN' from 'keys' (C:\Users\yahsk\Desktop\genesis\ecoute\ecoute\keys.py)" With the original files it was working properly and was facing no issues. I have the keys.py file in the folder with my openAI access key and am calling "python main.py --revChatGPT" Capture

Rakshay-pawar commented 9 months ago

Hi, @SevaSk,

I hope you're doing well. I wanted to let you know about a PR that I've submitted. It introduces a new feature to ecoute, allowing users to utilize it without the need for a paid OpenAI account. Could you please take a look and provide your feedback?

Thanks, Lunjie

Lunjie Hi Lunjie I downloaded your files and replaced them with the original files however I am getting an error "ImportError: cannot import name 'ACCESS_TOKEN' from 'keys' (C:\Users\yahsk\Desktop\genesis\ecoute\ecoute\keys.py)" With the original files it was working properly and was facing no issues. I have the keys.py file in the folder with my openAI access key and am calling "python main.py --revChatGPT"