Only static FFZ emotes are currently supported by 7TV. For animated emotes only the static version is used, probably because FFZ itself only added support for them rather recently. Because of that 7TV should add support for animated FFZ emotes as well.
Types of changes
What types of changes does your code introduce to 7TV?
Put an x in the boxes that apply
[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules
Further comments
The FFZ API has a field "animated" which returns a map of DPI scales to animated emote URLs and is null if the emote is not animated. This field was added to our interface and the transformer adjusted to use the correct url and file dependant on if the emote is animated or not.
Proposed changes
Only static FFZ emotes are currently supported by 7TV. For animated emotes only the static version is used, probably because FFZ itself only added support for them rather recently. Because of that 7TV should add support for animated FFZ emotes as well.
Types of changes
What types of changes does your code introduce to 7TV? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
The FFZ API has a field "animated" which returns a map of DPI scales to animated emote URLs and is null if the emote is not animated. This field was added to our interface and the transformer adjusted to use the correct url and file dependant on if the emote is animated or not.
Documentation from FFZ API: