search

SevenTV / Extension

The Web Extension for 7TV, bringing new features, emotes, vanity and performance to Twitch, Kick & YouTube
Other
379 stars 97 forks source link

[BUG] extension window very small #1052

Open mangkoran opened 2 weeks ago

mangkoran commented 2 weeks ago

Is there an existing issue for this?

This issue exists in the latest nightly version

What browsers are you seeing the problem on?

Chrome

Current Behavior

When I click extension icon, the extension window shows with very small width making it impossible to config. Note that I have disabled all of my extensions.

image

image

Expected Behavior

Extension window has normal width which show config.

Steps To Reproduce

  1. Install Chrome Version 126.0.6478.127 (Official Build) (64-bit)
  2. Install 7TV 3.0.9 or 7TV Nightly 3.0.15.1000 nightly
mangkoran commented 2 weeks ago

If I override the width manually it will show.

html[data-seventv-app] {
    box-sizing: border-box;
    font-family: Roboto, sans-serif;
    height: 100%;
    width: 400px; /* it was 100% before */
}

image

mangkoran commented 2 weeks ago

Also I was mistaken as I was looking for 7tv config and just now I found the button.

image

But the above issue still valid.

mangkoran commented 2 weeks ago

Looking at https://github.com/bitwarden/clients implementation, the height and width are absolute.

https://github.com/bitwarden/clients/blob/982031633cb6bdfe410c901888f3f6db6058d5e5/apps/browser/src/popup/scss/base.scss#L18-L19

image

mangkoran commented 2 weeks ago

I found hard-coded width/height in the code.

https://github.com/SevenTV/Extension/blob/cc924cbf4483a5436732526418d16002a6e7a6d1/src/app/options/views/Popup/Popup.vue#L21-L22

We could use this and put it in https://github.com/SevenTV/Extension/blob/master/src/assets/style/global.scss.