SevenTV / Extension

The Web Extension for 7TV, bringing new features, emotes, vanity and performance to Twitch, Kick & YouTube
Other
388 stars 98 forks source link

[BUG] "Hide Recommended Channels" now hides Followed Channels, "Hide Viewers Also Watch" now hides Recommended Channels #1061

Closed mrtnxby closed 1 month ago

mrtnxby commented 1 month ago

Is there an existing issue for this?

This issue exists in the latest nightly version

What browsers are you seeing the problem on?

Chrome

Current Behavior

Hi guys. So I logged on to Twitch today and noticed something unusual as I usually have my 7TV settings set to hide "Recommended Channels" and "Viewers Also Watch".

The "Hide Recommend Channels" and "Hide Viewers Also Watch" toggles were hiding the wrong parts of the sidebar. I noticed this when I couldn't find my Followed Channels in the sidebar unless I minimised it, as that shows the icons at least.

Probable Cause

I am 99% sure that this issue is due to the addition of Instagram-like stories to Twitch. I've never seen this before and saw that this is at the top of the sidebar now above Followed Channels and below the "For You" text / open and close sidebar toggle.

My gut feeling is that this has shifted all of the elements in the sidebar downwards down by one (not sure of a better way to phrase this) and that means that the hide toggles in the extension are probably targeting the wrong elements or the one directly above them.

Hoping this is an easy enough fix and also perhaps an opportunity to add in a "Hide Stories" toggle also, but I realise this is a big ask. It might be worth checking other toggles as well that may have been affected.

Video

https://github.com/user-attachments/assets/f0886646-a04a-49f9-9623-a91c73f56704

Hide Recommended Channels ON + Hide Viewers Also Watch ON:

bug1

Hide Recommended Channels OFF + Hide Viewers Also Watch ON:

bug2

Hide Recommended Channels OFF + Hide Viewers Also Watch OFF:

bug3

Hide Recommended Channels ON + Hide Viewers Also Watch OFF:

bug4

Expected Behavior

Steps to Reproduce:

Open 7TV and select Site Layout > Sidebar and toggle on and off the following:

Hide Viewers Also Watch:

Hide Recommended Channels:

mrtnxby commented 1 month ago

Ah, my apologies, I just saw this was already reported yesterday: https://github.com/SevenTV/SevenTV/issues/72

Closing on that basis, but feel free to use this if it's useful in any way.