search

SevenTV / Extension

The Web Extension for 7TV, bringing new features, emotes, vanity and performance to Twitch, Kick & YouTube
Other
395 stars 101 forks source link

[Bug] Too many messages when user gets banned #157

Closed emberfox closed 2 years ago

emberfox commented 3 years ago

Describe the bug Every time someone gets banned, multiple messages appear, saying the same thing. Maybe it's once for every message the user sent recently.

To Reproduce Steps to reproduce the behavior:

  1. Go to Shroud channel
  2. Wait for a ban
  3. See error

Expected behavior One message

Screenshots

repeat

Version: The version where the bug is occuring is 2.0 on firefox

Excellify commented 3 years ago

Can't reproduce the issue. Any other extentions you have installed that might interfere?

AnatoleAM commented 3 years ago

This is typically because bots in some channels may timeout the same user many times, leading to more messages. This could be fixed by employing the approach taken by Chatterino, where repeated timeouts are appended as "(x times)"

emberfox commented 3 years ago

Can't reproduce the issue. Any other extentions you have installed that might interfere?

try "allowing to send same message twice" on setting, I only noticed it after I messed with that *edit: I didn't mention it, because I disabled it and the bug kept on happening

This is typically because bots in some channels may timeout the same user many times, leading to more messages. This could be fixed by employing the approach taken by Chatterino, where repeated timeouts are appended as "(x times)"

Each user gets a different amount of msgs, so I don't think so

AnatoleAM commented 3 years ago

This is an issue native to the extension, which as I said is primarily because Twich can send more than a single timeout message. Although it's not impossible there's also a problem with code being duplicated, I'll have a look at this

Jexetic commented 2 years ago

Happening to me as well. Using FrankerFacez and 7TV, no BTTV. image I'm pretty certain the timeout isn't actually being issued this many times from a bot. Scrolling up and down seems to duplicate the message more, but it could just be because there's new chat messages coming in as I'm scrolling and not actually related to the scrolling itself.

Also, it seems to be more likely the longer I'm watching a stream. When I first enter the chat, generally timeout/bans are posted only once.

AnatoleAM commented 2 years ago

Confirmed fixed in 2.2.0