search

SevenTV / Extension

The Web Extension for 7TV, bringing new features, emotes, vanity and performance to Twitch, Kick & YouTube
Other
389 stars 98 forks source link

[Bug] Duplicate emote names across multiple emote services are not handled properly in the colon-completion popup #441

Open robmonte opened 1 year ago

robmonte commented 1 year ago

If a channel has two emotes with the same name in the channel from different emote providers, the list will skip entries when navigating it with the arrow keys and exhibits other strange behavior. A demonstration of what happens is below:

colonmenu

Notice how it highlights both emotes named lacSit, and then skips lacSip to go back up to the top of the list. The index is getting set to the lower of the emotes and because that is the last one in the list it loops back to the beginning.

Note: If there was another emote below the 2nd lacSit, it would have continued moving down from that position while still skipping lacSip. I've seen that behavior with another duplicate emote, but the list was too tall to screen record as a GIF.

AnatoleAM commented 1 year ago

This can happen if you have other extensions also appending data to the input completion box. Closing as there is no plan to work around this and it can be self-mitigated via settings. :+1:

robmonte commented 1 year ago

@AnatoleAM I realize I forgot to specify in my original post, but the screen recording was done with only the 7TV extension active and all other twitch-related extensions disabled. Are you saying there is still something else that could be causing it in this case?

AnatoleAM commented 1 year ago

@robmonte I think I understand what this is, sorry, these emotes are both a sub emote and third party. Since they have the same "token", they both get selected.

robmonte commented 1 year ago

No problem, sorry I didn't explain it clearly. Thanks for reopening.

TheRealGI commented 1 year ago

Does it make sense to have emotes which are not unique? Should a twitch channel emote( not global) and a third party emote sharing the same token? If we want to distinct them which one should we prioritize?

robmonte commented 1 year ago

Yes, I think it makes sense to have a channel emote (sub, follow, etc) overlap with third-party emotes. They should be higher priority than third party emotes in the case of a conflict.

It sometimes makes sense to have emotes that are not unique. In the example above, the emote is both a subscriber emote and BTTV emote so that all viewers including non-subs can use it in the channel, but only subscribers can use the emote in other chats.