SevenTV / Website

The 7TV Web App with the Vue framework
https://7tv.app
Other
38 stars 30 forks source link

Firefox 113 (Nightly) supports animated AVIF, 7TV site claims it doesn't #967

Closed CounterPillow closed 1 year ago

CounterPillow commented 1 year ago

Hot fresh off the presses, Firefox enabled animated AVIF support and is allowing it to pass into stable for 113.0: https://bugzilla.mozilla.org/show_bug.cgi?id=1825580

Using Firefox 113 (Nightly) right now confirms that animated AVIF images work now, but the 7TV website still claims it doesn't. image

berghall commented 1 year ago

Seems to be working on Windows Firefox Nightly 114.0a1 (2023-04-13) (64-bit) now. Could you try an update?

AnatoleAM commented 1 year ago

Firefox made a botched implementation of AVIF; by adding support for static images only, meaning that the browser reported to applications that the format is supported, even though it really wasn't. This means standard support detection mechanisms, such as <picture> tags, would have no use since it would still be rendered, albeit a static image.

That gave us no choice besides manually blacklisting Firefox user agents, we'll have to enable it once it's fully supported into the stable release.

CounterPillow commented 1 year ago

You can change this check already since it's in beta and will end up in stable for 113, no need to wait for the stable release, your change will be the same either way:

https://github.com/SevenTV/Website/blob/7cb35f1dd0b7467c30d8b48b8acf8b4f75673a01/src/store/actor.ts#L60

similar to chrome except I suppose "Firefox" and >= 113.

CounterPillow commented 1 year ago

Firefox 113 is out now. And I see someone fixed this already but didn't close this.