[macOS] bundle identifier is still "com.chatterino", same as the original

SevenTV / chatterino7

Chat client for https://twitch.tv

MIT License

359 stars 70 forks source link

[macOS] bundle identifier is still "com.chatterino", same as the original #197

Closed core-code closed 1 month ago

core-code commented 1 year ago

Checklist

[X] I'm reporting a problem with Chatterino
[X] I've verified that I'm running the most recent nightly build or stable release
[X] I've looked for my problem on the wiki
[X] I've searched the issues and pull requests for similar looking reports

Describe your issue

since Chatterino7 is a distinct app to the original, the CFBundleIdentifier in the Info.plist file should probably be changed from "com.chatterino" to something different so that the app can be distinguished from the original

Screenshots

No response

OS and Chatterino Version

7.4.2

core-code commented 5 months ago

same problem in 7.5.0

Nerixyz commented 5 months ago

I get the problem, but changing this retroactively would cause users that installed an older version of Chatterino7 to have two versions installed, even though they only want one. Not sure what the best solution is.

core-code commented 5 months ago

I get the problem, but changing this retroactively would cause users that installed an older version of Chatterino7 to have two versions installed, even though they only want one.

well, no, why could a bundle-id change cause this?

the only problem when changing the bundle-id of an app is preference migration. if you are using the native cocoa preferences system (NSDefaults), you'll need to kick off a migration from the previous bundle-id.

Nerixyz commented 5 months ago

I get the problem, but changing this retroactively would cause users that installed an older version of Chatterino7 to have two versions installed, even though they only want one.

well, no, why could a bundle-id change cause this?

the only problem when changing the bundle-id of an app is preference migration. if you are using the native cocoa preferences system (NSDefaults), you'll need to kick off a migration from the previous bundle-id.

Yea I have no clue how this works on macos I'd assume if you change the id, then it's a different app to the OS. So if you try to update/reinstall it would add a new app and not overwrite the old one (hence the need for a migration). If you know how that works, feel free to open a PR.

core-code commented 5 months ago

it would add a new app and not overwrite the old one

whether that happens depends on the name of the app in the filesystem, not the bundle-id.

core-code commented 1 month ago

thanks!