search

SevenTV / chatterino7

Chat client for https://twitch.tv
MIT License
359 stars 70 forks source link

Revert 1 fix/zero width #240

Closed jszeluga closed 1 year ago

jszeluga commented 1 year ago

Description

Nerixyz commented 1 year ago

If you have a fix for the CI jobs, feel free to PR them.

jszeluga commented 1 year ago

This PR was an error on my part. I do have a fix for the CI job, but I'm not sure how it affects the deb version, since I'm building against OpenSSL 1.1. If the deb is already broken and we don't care then sure I can open a PR. Otherwise I'm not really sure what to do. Also, I didn't use Conan, I just put all the OpenSSL stuff in the docker file

Nerixyz commented 1 year ago

If the deb is already broken and we don't care then sure I can open a PR.

Since it doesn't include the dependencies, I'd assume it's broken (though the Qt 6 one should be linked against OpenSSL 3 - e.g. libqt6network6 depends on libssl3).

Also, I didn't use Conan, I just put all the OpenSSL stuff in the docker file

That should be fine (less time (re-)building stuff is always a win), although CI doesn't actually use docker (afaik it's there as a replica of CI (?)), so you'd need to update build.yml.