search

SevenTV / chatterino7

Chat client for https://twitch.tv
MIT License
359 stars 70 forks source link

ci: use correct openssl location #279

Closed Nerixyz closed 2 weeks ago

Nerixyz commented 2 weeks ago

Fixes #278.

LosFarmosCTL commented 2 weeks ago

Looks like the arm64 part of the binary links to the absolute homebrew paths, while x86 correctly uses the framework folder relative to the execution path. Not exactly sure what causes that to happen though:

SCR-20241003-pubs
Nerixyz commented 2 weeks ago

@LosFarmosCTL could you try the universal build from this PR? https://github.com/SevenTV/chatterino7/actions/runs/11166845955?pr=279

LosFarmosCTL commented 2 weeks ago

Yup, it works again using the substitution.

Still no idea why it's not getting set correctly in the first place, I tried poking around locally the last two hours but couldn't find any fix. The macdeployqt call in .CI/MacDeploy.sh doesn't rewrite the paths correctly, but why it's only an issue for specifically libssl in the arm64 part is beyond me, since everything else does get set correctly. Looks like changing the install name afterwards is the best fix for the moment.

Nerixyz commented 2 weeks ago

Thank you! As far as I know, pajlada only used the fixes I had before this PR (for rewriting libssl's search paths), not sure why more adjustments are required now. I'm hoping Chatterino2 can use this in the future as well (would make the release process a bit more "open").