search

SevenTV / image-processor

The image processor which handles emote uploads
Other
4 stars 1 forks source link

Broken extracted frames likely from `dump_png`, likely due to color space tagging #84

Open brian6932 opened 1 year ago

brian6932 commented 1 year ago

The #bugs-and-stuff channel on Discord has has been archived, so I'm converting some issues to GitHub ones

To circumvent GitHub image processing, all files are href-ed to their original versions, there is no way to bypass GitHub image cache unfortunately

The issue does not seem to occur with files encoded as webp

Upload: https://7tv.app/emotes/638ef040b8a5da5f6fb69c7e

source file
webp encoded
avif encoded
png encoded

Same emote uploaded as webp (converted with cwebp): https://7tv.app/emotes/638f03689cb1d139f49aba0e

source file (converted to webp)

Upload: https://7tv.app/emotes/6391493c15aa81ee27cfb7d8 Small context: Uploaded as avif, because when png is uploaded, the file is immediately removed (with This emote is no longer available). Back when I first uploaded it, I remember the same issue occuring with png.

source file
webp encoded
avif encoded
png encoded

Same emote uploaded as webp (converted with cwebp): https://7tv.app/emotes/638f04488d6a5b789c785d55

source file (converted to webp)

Upload: https://7tv.app/emotes/6351eb1404c60cee7a31d672

source file
brian6932 commented 1 year ago

I have looked a bit further into this, and it seems to be due to images tagged with color spaces or just being 16 bit, the majority of these (not all), were taken in mpv, with screenshot-tag-colorspace set to yes.