SeverinDK / moment-timer

Timer plugin for Moment.js that allows creation of setInterval and setTimeout-like timers.
MIT License
110 stars 33 forks source link

update moment.js version and create nodejs example #27

Closed justbill2020 closed 3 years ago

justbill2020 commented 3 years ago

Minor version bump, Security fix

https://github.com/moment/moment/issues/4163 https://github.com/moment/moment/pull/4326

Update package.json and readme.

justbill2020 commented 3 years ago

@SeverinDK I thought you might want to review before merging. Also, I thought we might want to change the "master" branch to "main" as per the new standard on github.

Let me know your thoughts on both.

I will merge after I hear back from you and will rename the branch after you give the ok. I don't want to come in and fully take over.

SeverinDK commented 3 years ago

Nice one @justbill2020 - I will go over this tomorrow and get it merged in. Thank you for the contribution!

SeverinDK commented 3 years ago

@justbill2020 Looks good. You can go ahead with both things.

justbill2020 commented 3 years ago

OK, this is now merged. @SeverinDK will you have to tag it as a release and publish to NPM?

Also, my permissions don't allow me to rename the branch.