search

Severson-Group / AMDC-Firmware

Embedded system code (C and Verilog) which runs the AMDC Hardware
http://docs.amdc.dev/firmware
BSD 3-Clause "New" or "Revised" License
31 stars 5 forks source link

Add ability for timed logs in firmware #116

Open npetersen2 opened 4 years ago

npetersen2 commented 4 years ago

With the current logging implementation, once a log is started, it will continue until one of two events:

  1. The log gets full (100k samples)
  2. The user calls stop

We should add a third option where the user can specify a logging duration and the code will automatically stop recording samples after this happens. This will be more accurate than timing it in Python.

Nick-Hemenway commented 4 years ago

This would be a nice feature and the Python API wouldn't have to change at all. The API already has a logger.log(duration = 1) sort of function. You would just have to change the internals of the function.