Fix pcbtest application for REV E/F hardware target

Severson-Group / AMDC-Firmware

Embedded system code (C and Verilog) which runs the AMDC Hardware

http://docs.amdc.dev/firmware

BSD 3-Clause "New" or "Revised" License

30 stars 5 forks source link

Fix pcbtest application for REV E/F hardware target #368

Closed npetersen2 closed 2 months ago

npetersen2 commented 2 months ago

Resolves: #369

@DivyaMendpara and I tested this on the new AMDC REV F hardware---it works as expected and says the hardware passes the test.

DivyaMendpara commented 2 months ago

@npetersen2 Looks good to me!

codecubepi commented 2 months ago

Also, is this being merged into develop to be included in the v1.2.0 firmware release which targets REV F hardware?

npetersen2 commented 2 months ago

Thanks @DivyaMendpara and @codecubepi .

@codecubepi--yes, this will be released as part of the v1.2.0 tag. Also, I agree we should go through and update the comments to better indicate REV E/F supported features, etc... but I think it is ok to let this one pass.