Closed codecubepi closed 5 months ago
Hey @codecubepi , while you do this, you may also want to put the enable_bits
and anything else in the timing manager IP hierarchy in the same (and following) order, for consistency:
and any new sensor peripherals will follow.
I've addressed the FPGA and C code changes in 00b695f.
I'll leave the updates to the README to @annikaolson
@annikaolson will update the README in the upcoming PR she will make
Looks good in PR #392 :
I'll close this now.
Abstract
Once my FPGA changes have been merged with @annikaolson 's C code changes back into
v1.3-staging
, we should probably go in and re-arrange the slv_regs tobe a more logical order.The current order is:
I think the following would make more sense:
This is because all the configuration registers at the beginning (lower addresses) are unlikely to be deleted or rearranged, and all of the sensor times are at the end, so that future sensors added are just added to the end of the list.
This will require:
timing_manager.h
header file like so:https://github.com/Severson-Group/AMDC-Firmware/blob/ffb82a68fb8ad68202e5c96c3ce61c1d4cb02859/sdk/app_cpu1/common/drv/amds.h#L24-L36