Fix component designators on uInverter revB PCB silkscreen

Severson-Group / AMDC-Hardware

Circuit board designs for controlling advanced motor systems

http://docs.amdc.dev/hardware

34 stars 3 forks source link

Fix component designators on uInverter revB PCB silkscreen #217

Closed purohitparth25 closed 2 years ago

purohitparth25 commented 2 years ago

This PR fixes Issue #216 .

In the uInverter revB, silkscreen annotation is done using a crude Re-annotate feature to avoid printing channel names in component designators. However, the component designators in the schematic and the BOM have channel names which caused mismatch between the designators in BOM/Schematic and the PCB silkscreen.

Fixed in this PR:

PCB silkscreen designator format changed to a more appropriate $Component$ChannelAlpha form

Before:

After:

Fixed PWM testpoint designator PWM-A1$ChannelAlpha to PWM$ChannelAlpha
Fixed sheet designator names in the main schematic page

Before:

After:

purohitparth25 commented 2 years ago

@elsevers This PR is ready for review and discussion.

purohitparth25 commented 2 years ago

@anirudhupadhyaya @mslaffin @shamagvasisht

Can you please verify if the silkscreen designators match with the Schematic/BOM sheet? Thanks!

mslaffin commented 2 years ago

Labelling the phase on the silkscreen makes it much more readable. Looks good to me.

purohitparth25 commented 2 years ago

@purohitparth25 Make 2 PRs:

[x] Modify BOM in revB folder - add column to map schematic designators and silkscreen designators
[x] Another PR for revC with the fixed silkscreen designators

purohitparth25 commented 2 years ago

Refer to following PRs created to incorporate the above changes: