Closed DivyaMendpara closed 10 months ago
@codecubepi can you also review this PR?
@DivyaMendpara please update the Project Parameters to change the Revision to be F
.
You'll notice on the schematic sheets lower-right box it still says E
. Once you update the Project Parameters, it should update on all sheets.
@codecubepi can you also review this PR?
- Open in Altium
- Verify changes to modified files
- Review each issue in the REV F milestone and add an issue comment per your review (see the REV E milestone and issue reviews as examples)
- Run checks to ensure design passes DRC for PCB and schematic review
@npetersen2
I will check it out!
@DivyaMendpara
This looks pretty good to me! Thank you for addressing #211 for me!
I do have some questions on the routing for #226 :
Is there a reason this trace for GPIO4_IN3_P wraps around the via? Is this a length-match? If it's not, I think we could take the trace directly to the via (like the dashed red line). If it is a length-match, disregard.
Why is there a trace loop on GPIO1_IN2_N?
@npetersen2
I went through all the issues under the REV F milestone and added my comments.
Questions:
Don't differential signals need to be length/impedance matched usually? I'd like to confirm that the new traces to the termination resistors will not have any negative signal integrity effects.
Do we need to update the Revision Changes SchDoc with info on REV F?
I ran a DRC (cut-down version here: AMDC_REV_F_DRC.pdf) and had a number of Solder Mask Sliver and Silk to Solder violations... anything to be concerned about here?
@codecubepi thanks for the review! Regarding your comments:
@DivyaMendpara once you have addressed the trace routing issues @codecubepi identified, please ask @codecubepi to review once again the routing. Then, upon approval, you can generate the REVxxxxF/
design output folder and add it to git in this PR. We will then review the compiled output to make sure it is correct and then approve for ordering. Please follow the directions here for how to export the design.
@npetersen2 and @codecubepi I created AMDC Rev F folder and uploaded design outputs (schematics, BOM, etc.) from Altium Designer. Please review and give your feedback.
@DivyaMendpara which capacitor part number did you change in the previous commit?
@npetersen2, I changed below capacitor value (now it is 0.1uF). Total qty (40+45). <html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns="http://www.w3.org/TR/REC-html40">
45 | 1276-1012-6-ND | C6, C7, C9, C10, C11, C12, C14, C15, C16, C17, C19, C20, C21, C23, C31, C32, C33, C34, C65, C66, C67, C68, C69, C70, C92, C93A, C93B, C93C, C93D, C93E, C93F, C93G, C93H, C94A, C94B, C94C, C94D, C94E, C94F, C94G, C94H, C118A, C118B, C119A, C119B | Capacitor | 0.1uF | 0603-CAP -- | -- | -- | -- | -- | -- 40 | 1276-1012-6-ND | C24, C25, C27, C28, C29, C30, C71A, C71B, C71C, C71D, C71E, C71F, C73A, C73B, C73C, C73D, C73E, C73F, C74A, C74B, C74C, C74D, C74E, C74F, C76A, C76B, C76C, C76D, C76E, C76F, C99, C100, C101, C102, C107, C110, C111, C112, C113, C114 | Capacitor | 100nF | 0603-CAP
This PR details modification made in AMDC Rev F board
Following changes were made for addressing issue #189
36-9900-ND
Following changes were made for addressing issue #227
Following changes were made for addressing issue #226
Following changes were made for addressing issue #211