Motherboard REV C - Githubissues

Severson-Group / AMDS

Voltage and Current Sense Board

BSD 3-Clause "New" or "Revised" License

2 stars 1 forks source link

Motherboard REV C #6

Closed ASHAD1 closed 4 years ago

ASHAD1 commented 4 years ago

This PR has the Motherboard REVC design files.

elsevers commented 4 years ago

@ASHAD1 Also fix:

Schematics PDF doesn't match your Altium files / what was ordered.
Title block on schematics is not fully populated:

ASHAD1 commented 4 years ago

As per the review comments, I have made the following changes,

Updated schematic PDF as per the latest Altium schematic, I have also updated title block
I have also organized the repository by referring to the AMDC-hardware repository.
I have fixed the issue of the VoltageCard directory which was changed.

I have not added a markdown document for the new measurement card hardware. Apart from this please let me know if any changes are required before we close this pull request.

npetersen2 commented 4 years ago

@ASHAD1 let's update the REVxxxx folder to use the REVYYYYMMDD convention. I think you have put the day first.

elsevers commented 4 years ago

This PR should be squash-merged to avoid extraneous files from appearing in the commit history and inflating the repo size.

ASHAD1 commented 4 years ago

I have made the following changes per the review comments.

Added markdown documentation
Updated REVxxxx folder to use the REVYYYYMMDD convention

Please let me know if anything else needs to be changed

ASHAD1 commented 4 years ago

I have implemented the changes as per the review comments.

I think I have implemented all the review comments from @elsevers , Please let me know if this is fine or any further changes required.

ASHAD1 commented 4 years ago

@npetersen2 @elsevers I have updated block diagram as per @npetersen2 suggestion. Please let me know if there are any changes required to merge PR.

@npetersen2 I agree that the SPI signals to DCs are confusing, this mistake happened when I reannotated designators, I will fix this in next revision.

npetersen2 commented 4 years ago

@ASHAD1, almost, but you need to show on the block diagram which MCU SPI peripherals go to which group of daughtercards (see my diagram).

ASHAD1 commented 4 years ago

@npetersen2 I have updated the block diagram to include SPI peripheral number as shown below

@elsevers @npetersen2 Let me know if this is ready for merging.

npetersen2 commented 4 years ago

@ASHAD1 Excellent, this looks good! Let's merge this in. If I recall, @elsevers requested we do a "Squash + Merge"

I'll let one of you click the buttons for this. Make sure that when you delete the branch, your REV D branch is still ok.