SforAiDl / Playground

A python library consisting of pipelines for visual analysis of different sports using Computer Vision and Deep Learning.
MIT License
18 stars 17 forks source link

Saving prediction as jpeg, sample video output and uniform usage of opencv #33

Closed Sharanranjit closed 4 years ago

ashwinvaswani commented 4 years ago

Hey. It looks okay but I'd mentioned having a save_figure flag set to false by default and only saving predictions when explicitly required by user. Kindly check the comments on that issue that I updated recently and update your PR. Best of luck!

ashwinvaswani commented 4 years ago

Rest seems okay

Sharanranjit commented 4 years ago

Yep, its done now. Also, I think the FPS issue is solved now that we are writing back the output frames, you can view the sample_video_output i have committed.

ashwinvaswani commented 4 years ago

Yes but by FPS issue, I meant while rendering( total processing time of video) before output video is ready