SforAiDl / decepticonlp

Python Library for Robustness Monitoring and Adversarial Debugging of NLP models
MIT License
15 stars 10 forks source link

Typo Perturbation w/ Assertions #29

Closed parantak closed 4 years ago

parantak commented 4 years ago

Facing some issues with Git.

  1. Re synced with base repository
  2. Black formatting is done.
codecov[bot] commented 4 years ago

Codecov Report

Merging #29 into master will increase coverage by 0.08%. The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   88.09%   88.18%   +0.08%     
==========================================
  Files           5        5              
  Lines          84      110      +26     
==========================================
+ Hits           74       97      +23     
- Misses         10       13       +3     
Impacted Files Coverage Δ
decepticonlp/transforms/perturb.py 79.36% <88.46%> (+6.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2991fb7...41be8a6. Read the comment docs.

someshsingh22 commented 4 years ago

Add the unit test for this too, maybe that is why the code coverage is not complete @parantak

parantak commented 4 years ago

@someshsingh22 and @rajaswa, could you perhaps help me with this codecov thing. I've hit a roadblock here.

parantak commented 4 years ago

Add the unit test for this too, maybe that is why the code coverage is not complete @parantak

oh okay, that could be the case, I'll try that

someshsingh22 commented 4 years ago

Yes, Check out the tests directory, also try to stick to the naming conventions for .py files and all functions as possible

someshsingh22 commented 4 years ago

There is some implementation error now, @parantak check the build log for the exact error here

parantak commented 4 years ago

All tests complete.