SforAiDl / genrl

A PyTorch reinforcement learning library for generalizable and reproducible algorithm implementations with an aim to improve accessibility in RL
https://genrl.readthedocs.io
MIT License
402 stars 59 forks source link

Mujoco, PyBullet support #125

Open Sharad24 opened 4 years ago

Sharad24 commented 4 years ago

We should develop an environment module with wrappers. For a starter, I find TF Agents env module pretty good.

sampreet-arthi commented 4 years ago

I'll work on Atari wrappers.

Sharad24 commented 4 years ago

Ok sure. I'm making a list of some that we should support at the very least, and some that we can think of adding.

Sharad24 commented 4 years ago
sampreet-arthi commented 4 years ago

I'll do generic wrappers too if that's fine

Sharad24 commented 4 years ago

Sure. Just ensure they are compatible with vecenvs which we should also move under this module.

On Wed, 20 May 2020, 04:02 Sampreet, notifications@github.com wrote:

I'll do generic wrappers too if that's fine

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SforAiDl/genrl/issues/125#issuecomment-631120450, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH72FJ6IVWR5HFX5PRFE3ZLRSMCGDANCNFSM4NE2KDLQ .

sampreet-arthi commented 4 years ago

Hmm... Okay. Should I also accommodate for classical models or only the deep models? Depending on that, I'll add a folder called wrappers (or) environments under genrl or genrl/deep.

Sharad24 commented 4 years ago

If you can, thats definitely better

sampreet-arthi commented 4 years ago

Also, I think it would be a good idea to move VecEnv.py into this folder too. It makes more sense keeping it environments rather than in deep/common

Sharad24 commented 4 years ago

Yeah that makes sense.

On Wed, 20 May 2020, 21:15 Sampreet, notifications@github.com wrote:

Also, I think it would be a good idea to move VecEnv.py into this folder too. It makes more sense keeping it environments rather than in deep/common

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SforAiDl/genrl/issues/125#issuecomment-631558568, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH72FJ224FMLW523YDF67WDRSP3KJANCNFSM4NE2KDLQ .

sampreet-arthi commented 4 years ago

Do we want pybullet and mujoco by v0.1?

Sharad24 commented 4 years ago

I think we should probably focus on getting what we have better structured first (internally) but let anyone else (not a core contributor) work on this.

github-actions[bot] commented 4 years ago

Stale issue message