SforAiDl / genrl

A PyTorch reinforcement learning library for generalizable and reproducible algorithm implementations with an aim to improve accessibility in RL
https://genrl.readthedocs.io
MIT License
403 stars 59 forks source link

Add imports to agent nested __init__.py #290

Closed mehulrastogi closed 4 years ago

Sharad24 commented 4 years ago

Is there a reason to have this, though?

I cleaned up the tree, purposely actually. What happens is there is a recursive creation of packages, modules at every level.

mehulrastogi commented 4 years ago

oh, I see cool will roll back! Also, let me know if genetic tutorial needs some changes as I don't see that in the master branch right now

mehulrastogi commented 4 years ago

https://www.reddit.com/r/Python/comments/1bbbwk/whats_your_opinion_on_what_to_include_in_init_py/ Just read the above post. I think your approach is much better for us

lgtm-com[bot] commented 4 years ago

This pull request fixes 2 alerts when merging 589a3619497b38eaa376168c78b9f84d4ff434e5 into dc2d58bdade1c5239ccc0925aeda78d1dc59e972 - view on LGTM.com

fixed alerts: