search

SforAiDl / genrl

A PyTorch reinforcement learning library for generalizable and reproducible algorithm implementations with an aim to improve accessibility in RL
https://genrl.readthedocs.io
MIT License
403 stars 59 forks source link

Shared parameters for actor and critic #307

Closed hades-rp2010 closed 3 years ago

hades-rp2010 commented 4 years ago

Wrt #225 , Still working on the multiactorcritics

codecov[bot] commented 4 years ago

Codecov Report

Merging #307 into master will increase coverage by 0.22%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   90.06%   90.28%   +0.22%     
==========================================
  Files          88       88              
  Lines        3694     3779      +85     
==========================================
+ Hits         3327     3412      +85     
  Misses        367      367
Impacted Files Coverage Δ
genrl/agents/deep/base/offpolicy.py 97.40% <ø> (ø)
genrl/agents/deep/a2c/a2c.py 93.58% <100.00%> (+0.34%) :arrow_up:
genrl/agents/deep/base/base.py 93.75% <100.00%> (+0.20%) :arrow_up:
genrl/agents/deep/ddpg/ddpg.py 92.85% <100.00%> (+0.54%) :arrow_up:
genrl/agents/deep/ppo1/ppo1.py 100.00% <100.00%> (ø)
genrl/agents/deep/sac/sac.py 93.33% <100.00%> (+0.22%) :arrow_up:
genrl/agents/deep/td3/td3.py 93.10% <100.00%> (+0.37%) :arrow_up:
genrl/core/actor_critic.py 97.94% <100.00%> (+1.69%) :arrow_up:
sampreet-arthi commented 4 years ago

Also, take a look at codacy

Sharad24 commented 3 years ago

Is this good to merge?

Sharad24 commented 3 years ago

Can you incorporate the suggested changes?

hades-rp2010 commented 3 years ago

Can you incorporate the suggested changes?

I've done this. Put the comments on the reshaping stuff, and changed the names as you requested. So Yes, it is good to merge

Sharad24 commented 3 years ago

Have you tried training the shared actor critics? Could you add a short documentation file on how to use shared actor critics?

Will merge it post these

hades-rp2010 commented 3 years ago

Have you tried training the shared actor critics? Could you add a short documentation file on how to use shared actor critics?

Will merge it post these

Yep, they are training I'll get working on the documentation

Sharad24 commented 3 years ago

This good to merge?

hades-rp2010 commented 3 years ago

If the tutorial added needs no additions/modifications, then yep

Sharad24 commented 3 years ago

The doc file needs to be added in an appropriate index or some other file. It would not show up anywhere right now

hades-rp2010 commented 3 years ago

The doc file needs to be added in an appropriate index or some other file. It would not show up anywhere right now

Added it in index.rst in the tutorials folder.