Closed hades-rp2010 closed 3 years ago
I think feature params should be added to both. Not sure though
Yeah, checked by printing out the weights. I'll add this too in my current PR. I'll close this for now?
Raise a separate PR, if possible.
On 03-Sep-2020, at 8:00 PM, hades-rp2010 notifications@github.com wrote:
Yeah, checked by printing out the weights. I'll add this too in my current PR. I'll close this for now?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SforAiDl/genrl/issues/315#issuecomment-686531686, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH72FJ66OIR6D7F2TQ7QTFLSD6R6RANCNFSM4QS3A3RQ.
Closing this for now
The weights of the CNN layers dont get updated in the CNN AC classes. Formally, this is what I mean -
The CNN actor critic class -
Above,
self.feature
is thenn.Sequential
object to be used (The CNN) But the optimizers in the agents -The
self.ac.actor.parameters()
andself.ac.critic.parameters()
are just the params of the actor head and the critic head. So what aboutself.ac.feature.parameters()
? That does not seem to be updated anywhere