SforAiDl / genrl

A PyTorch reinforcement learning library for generalizable and reproducible algorithm implementations with an aim to improve accessibility in RL

https://genrl.readthedocs.io

MIT License

403 stars 59 forks source link

[WIP] Adding MultiAgent Utilities #323

Open AdityaKapoor74 opened 4 years ago

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging 0927001fa98545de813be9cb6610bc557476cf86 into c3ef4d9265c18f587b3f7b79f8c18fec8c69955a - view on LGTM.com

new alerts:

1 for Variable defined multiple times

Sharad24 commented 4 years ago

Looks pretty good.

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging daa8b2ac9ea6b785279c2a96e6810f03d68857f0 into c3ef4d9265c18f587b3f7b79f8c18fec8c69955a - view on LGTM.com

new alerts:

1 for Syntax error
1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging 44db72eafe343f5ddf10bf996af5f2a2d8f5fd96 into c3ef4d9265c18f587b3f7b79f8c18fec8c69955a - view on LGTM.com

new alerts:

1 for Syntax error
1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging d8cf1a92cbaf3ef926e70b62cf6f6db8438bc2d8 into c3ef4d9265c18f587b3f7b79f8c18fec8c69955a - view on LGTM.com

new alerts:

1 for Syntax error
1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 5 alerts when merging 1365585b4daae5c505d448db3958b8474466129c into c3ef4d9265c18f587b3f7b79f8c18fec8c69955a - view on LGTM.com

new alerts:

2 for Syntax error
2 for First argument to super() is not enclosing class
1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 5 alerts when merging 6f0563e885738ac58d3fe4299596e8f0288cfa6b into c3ef4d9265c18f587b3f7b79f8c18fec8c69955a - view on LGTM.com

new alerts:

2 for Syntax error
2 for First argument to super() is not enclosing class
1 for Variable defined multiple times

lgtm-com[bot] commented 4 years ago

This pull request introduces 7 alerts when merging 5061abe111efbb0324b52b02920d639ba9da6362 into 0fe41807d67ea504e0b57dc429402a3a99d2c253 - view on LGTM.com

new alerts:

2 for Mismatch between signature and use of an overriding method
2 for Wrong number of arguments in a class instantiation
1 for First argument to super() is not enclosing class
1 for Variable defined multiple times
1 for Wrong number of arguments in a call

codecov[bot] commented 4 years ago

Codecov Report

Merging #323 into master will decrease coverage by 3.46%. The diff coverage is 36.07%.

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   90.77%   87.31%   -3.47%     
==========================================
  Files          89       89              
  Lines        3772     4027     +255     
==========================================
+ Hits         3424     3516      +92     
- Misses        348      511     +163

Impacted Files	Coverage Δ
genrl/agents/deep/a2c/a2c.py	`93.58% <ø> (ø)`
genrl/agents/deep/ddpg/ddpg.py	`83.05% <0.00%> (-4.45%)`	:arrow_down:
genrl/core/rollout_storage.py	`56.04% <9.21%> (-33.58%)`	:arrow_down:
genrl/environments/suite.py	`73.68% <11.11%> (-19.42%)`	:arrow_down:
genrl/core/buffers.py	`63.72% <12.82%> (-31.52%)`	:arrow_down:
genrl/environments/gym_wrapper.py	`54.21% <27.50%> (-24.86%)`	:arrow_down:
genrl/agents/deep/ppo1/ppo1.py	`97.61% <33.33%> (-2.39%)`	:arrow_down:
genrl/utils/utils.py	`86.62% <78.82%> (-7.63%)`	:arrow_down:

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging e6a378c3a7d94afb46153b8254c50f6c3ab3350e into 0fe41807d67ea504e0b57dc429402a3a99d2c253 - view on LGTM.com

new alerts:

1 for First argument to super() is not enclosing class