search

SforAiDl / jeta

A Jax based meta learning library
MIT License
16 stars 12 forks source link

Add CI checks and setup #10

Closed Yash-10 closed 2 years ago

Yash-10 commented 2 years ago

From #9. Needed to modify setup.cfg, otherwise yielded build errors.

Few changes in src files were made due to the new CI checks, otherwise gave errors.

veds12 commented 2 years ago

@Yash-10 can you solve the conflicts arising due to the renaming?

Yash-10 commented 2 years ago

I saw metadata from setup.cfg was transferred to setup.py. Needed to add MANIFEST.in, else gave errors during tox invocation.

Yash-10 commented 2 years ago

@veds12 I think the only other suggestion was to remove src/jeta and instead keep it as jeta, right? If yes, I think this is ready for a final review...

veds12 commented 2 years ago

Yes, thanks. I have been occupied this week. I'll try to review and merge tomorrow.

On Fri, Jan 28, 2022, 20:40 Yash-10 @.***> wrote:

@veds12 https://github.com/veds12 I think the only other suggestion was to remove src/jeta and instead keep it as jeta, right? If yes, I think this is ready for a final review...

— Reply to this email directly, view it on GitHub https://github.com/SforAiDl/jeta/pull/10#issuecomment-1024311951, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANCPEQX5NFXVYQV32WMPBKDUYKWVBANCNFSM5MD6NHMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>